fix: Handle ngrok config upgrade error in createTunnel function#295
Merged
ericallam merged 3 commits intotriggerdotdev:mainfrom Aug 11, 2023
Merged
fix: Handle ngrok config upgrade error in createTunnel function#295ericallam merged 3 commits intotriggerdotdev:mainfrom
ericallam merged 3 commits intotriggerdotdev:mainfrom
Conversation
🦋 Changeset detectedLatest commit: d587cfe The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue where the
createTunnelfunction fails to handle a specific ngrok error message that indicates the requirement for aversionproperty in the configuration. The code has been refactored to handle this error message appropriately and perform the necessary configuration upgrade before retrying the tunnel creation.Changes Made
createTunnelfunction to identify and handle the ngrok error message indicating the need for aversionproperty in the configuration.ngrok config upgradecommand when the error message is detected.How to Test
versionproperty from the ngrok configuration.createTunnelfunction with a test port.Fixes #284
/claim #284