Fix CLI downgrade check (#1380)

nicktrn · web-flow · commit c5488df8ca68 · 2024-10-05T13:12:47.000+01:00
* fix downgrade detection

* remove unused semver package from webapp

* add changeset
diff --git a/.changeset/fuzzy-files-hunt.md b/.changeset/fuzzy-files-hunt.md
@@ -0,0 +1,5 @@
+---
+"trigger.dev": patch
+---
+
+Fix downgrade check by correctly comparing semvers
diff --git a/apps/webapp/package.json b/apps/webapp/package.json
@@ -161,7 +161,6 @@
     "remix-typedjson": "0.3.1",
     "remix-utils": "^7.1.0",
     "seedrandom": "^3.0.5",
-    "semver": "^7.5.0",
     "simple-oauth2": "^5.0.0",
     "simplur": "^3.0.1",
     "slug": "^6.0.0",
@@ -210,7 +209,6 @@
     "@types/react-dom": "18.2.7",
     "@types/regression": "^2.0.6",
     "@types/seedrandom": "^3.0.8",
-    "@types/semver": "^7.3.13",
     "@types/simple-oauth2": "^5.0.4",
     "@types/slug": "^5.0.3",
     "@types/tar": "^6.1.4",
diff --git a/packages/cli-v3/package.json b/packages/cli-v3/package.json
@@ -52,7 +52,7 @@
     "@types/react": "^18.2.48",
     "@types/resolve": "^1.20.6",
     "@types/rimraf": "^4.0.5",
-    "@types/semver": "^7.3.13",
+    "@types/semver": "^7.5.0",
     "@types/source-map-support": "0.5.10",
     "@types/ws": "^8.5.3",
     "cpy-cli": "^5.0.0",
@@ -112,6 +112,7 @@
     "partysocket": "^1.0.2",
     "pkg-types": "^1.1.3",
     "resolve": "^1.22.8",
+    "semver": "^7.5.0",
     "signal-exit": "^4.1.0",
     "source-map-support": "0.5.21",
     "std-env": "^3.7.0",
diff --git a/packages/cli-v3/src/commands/update.ts b/packages/cli-v3/src/commands/update.ts
@@ -13,6 +13,7 @@ import { spinner } from "../utilities/windows.js";
 import { VERSION } from "../version.js";
 import { hasTTY } from "std-env";
 import nodeResolve from "resolve";
+import * as semver from "semver";
 
 export const UpdateCommandOptions = CommonCommandOptions.pick({
   logLevel: true,
@@ -112,7 +113,7 @@ export async function updateTriggerPackages(
     }
 
     const isDowngrade = mismatches.some((dep) => {
-      return dep.version > targetVersion;
+      return semver.gt(dep.version, targetVersion);
     });
 
     return {
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"trigger.dev": patch
 +---
++
 +Fix downgrade check by correctly comparing semvers