Fixes App crash when left for a long time#160
Merged
ericallam merged 6 commits intotriggerdotdev:mainfrom May 25, 2023
tobihans:fix/app-crash
Merged
Fixes App crash when left for a long time#160ericallam merged 6 commits intotriggerdotdev:mainfrom tobihans:fix/app-crash
ericallam merged 6 commits intotriggerdotdev:mainfrom
tobihans:fix/app-crash
Conversation
ericallam
requested changes
May 24, 2023
Member
ericallam
left a comment
There was a problem hiding this comment.
Looks good! Made a few comments and once those are addressed this can be merged in
Member
|
Thanks for the review @afzalsayed96! @tobihans do you think you could address the issues they raised in the PR? |
Contributor
Author
|
Yes @ericallam, I just submitted the changes. To be honest, I'm new to React (long time Vue dev :-) ). But I'm learning a lot from @afzalsayed96 review. Do let me know if this resolves it. Thanks |
|
Rest looks good. Please make sure this runs well as I haven't tested this myself. |
Contributor
Author
|
Yes, it does, I have tested it. Below is an attached demo. Thanks sample.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #95.
The cause was a failing request for URL preview once the user is disconnected.
The current state of error handling with Remix doesn't allow to handle network errors manually when using
useFetcher.To workaround this, we detect if the user is online before loading the preview. In addition to that, errors are catched on the loader and an error response is returned.
/claim #95