Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
fa60abb to
1f10919
Compare
bjorn3
reviewed
Mar 27, 2025
libz-rs-sys-cdylib/Cargo.toml
Outdated
| [features] | ||
| default = ["c-allocator"] # when used as a cdylib crate, use the c allocator | ||
| # when used as a cdylib crate, use the c allocator, and export the symbols so they are visible to the linker | ||
| default = ["c-allocator", "export-symbols"] |
Collaborator
There was a problem hiding this comment.
I think libz-rs-sys-cdylib should unconditionally enable the export-symbols feature of libz-rs-sys. There is no way to use it with export-symbols disabled. Rustc will simply not export the symbols from the cdylib if it isn't and will likely remove almost the entirety of the cdylib as dead code.
1f10919 to
e2a8e71
Compare
e2a8e71 to
3a915a0
Compare
bjorn3
approved these changes
Mar 27, 2025
This was referenced Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #321