Restore linker errors for incomplete binaries#7
Merged
trhodeos merged 2 commits intotrhodeos:masterfrom Sep 5, 2020
ChrisPVille:upstream
Merged
Restore linker errors for incomplete binaries#7trhodeos merged 2 commits intotrhodeos:masterfrom ChrisPVille:upstream
trhodeos merged 2 commits intotrhodeos:masterfrom
ChrisPVille:upstream
Conversation
The "-noinhibit-exec" has the side-effect of inhibiting most errors emitted by ld, including the overlapping section errors or undefined reference errors. Even when these are explicitly enabled noinhibit-exec will cause the link to silently succeed at generating a broken binary.
…useg buffers into Kseg0
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #6 by removing the noinhibit-exec flag. As a result, some of the demos which previously built (but did not work) now complain about why they won't work.
With a modern GCC10 toolchain most of those problems were either the Kuseg zbuffer/cfb/etc. sections trying to load into Kseg0 (which @lambertjamesd fixed), or the use of functions from libgcc that is not built following some N64 homebrew guides.