@0x2b3bfa0 hey, as an expert in this, could you please review and see that we are not missing anything and/or there are better ways to organize it now (run tests for external contributions after an approval).

@mattseddon wrote me a Slack direct message a dozen hours ago asking the same, hence e4e23aa 👍🏼

See also

• Allow access to secrets for external contributors iterative/cml#574 (comment)

@0x2b3bfa0 shouldn't the checks be run when I open a PR?

@0x2b3bfa0 shouldn't the checks be run when I open a PR?

Because the checks are run in the context of the base branch authorize is not available. See #2645 for when the checks do get run. Will need to merge this in two parts. With on: pull_request and then remove that trigger afterwards.

Code Climate has analyzed commit 9c59ba3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

This seems like a bug in paambaati/codeclimate-action@v3.1.1

The problem is here:

https://github.com/paambaati/codeclimate-action/blob/8788c820257f80343c47eb820a5f1cd9763e3faf/src/main.ts#L38

The line needs to be extended to include pull_request_target

Raised paambaati/codeclimate-action#627. This is blocked until that gets resolved.

It's hacky, but you could use an env block to override those environment variables for the action.

E.g.

      - uses: paambaati/codeclimate-action@v3.1.1
        env:
          CC_TEST_REPORTER_ID: ${{secrets.CC_TEST_REPORTER_ID}}
          GITHUB_EVENT_NAME: ${{ github.event_name == 'pull_request_target' && 'pull_request' || github.event_name }}
        with:
          coverageCommand: xvfb-run -a yarn run cover
          coverageLocations: ${{github.workspace}}/coverage/lcov.info:lcov

E.g.

      - uses: paambaati/codeclimate-action@v3.1.1
        env:
          CC_TEST_REPORTER_ID: ${{secrets.CC_TEST_REPORTER_ID}}
          GITHUB_EVENT_NAME: ${{ github.event_name == 'pull_request_target' && 'pull_request' || github.event_name }}
        with:
          coverageCommand: xvfb-run -a yarn run cover
          coverageLocations: ${{github.workspace}}/coverage/lcov.info:lcov

It doesn't seem like overriding the environment variables like this has any effect on the action 😞.

Code Climate has analyzed commit a217a20 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.