Typo on flatten-dict dependency #10953
Conversation
Should be flatten-dict with a hyphen instead of underscore according to https://pypi.org/project/flatten-dict/
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10953 +/- ##
==========================================
+ Coverage 90.68% 90.98% +0.30%
==========================================
Files 504 505 +1
Lines 39795 41083 +1288
Branches 3141 3255 +114
==========================================
+ Hits 36087 37380 +1293
- Misses 3042 3064 +22
+ Partials 666 639 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@weiji14, in Python packaging, That said, I am okay with this changes. |
|
Ah, didn't know that PyPI/pip handled that! Yes, conda is more sensitive (since it is not Python only). I did find conda/grayskull#228 and conda/grayskull#230 (comment), but those don't seemed to be actioned yet, so would prefer if we use |
|
Thank you @weiji14 for fixing this, and also helping to migrate conda recipe to v1 format. 🙏🏽 |
Should be
flatten-dictwith a hyphen instead of underscore according to https://pypi.org/project/flatten-dict and https://github.com/ianlini/flatten-dict.This has been tripping up the conda-forge auto-update bot since conda-forge/dvc-feedstock@6d439cf (had to manually remove
flatten_dictin favour offlatten-dict).❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏