Fixes #48: Support PHP 7.4 typed properties#56
Merged
maxbrunsfeld merged 1 commit intotree-sitter:masterfrom Mar 27, 2021
Merged
Fixes #48: Support PHP 7.4 typed properties#56maxbrunsfeld merged 1 commit intotree-sitter:masterfrom
maxbrunsfeld merged 1 commit intotree-sitter:masterfrom
Conversation
Contributor
|
Thank you, your work looks great. I appreciate all the tests that you added. That one conflict that you added (for |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for type properties according to https://wiki.php.net/rfc/typed_properties_v2
Note: This is my first go at using tree-sitter and improving the PHP parser. So any input on how to improve the contribution would be greatly appreciated. E.g. I was unable to figure out how to avoid adding a new conflict rule. Any pointers on a more elegant solution?
Note2: I've also added some more tests around classes. The PHP code in these are from https://github.com/nikic/PHP-Parser which, to my knowledge, is the most complete PHP parser. They're however BSD-3 licenced. Should this be avoided or annotated in a special way?