Skip to content

Use python 3.12 and update node-gyp to 10.0.1#198

Merged
cfroystad merged 1 commit intotree-sitter:masterfrom
piotrkwiecinski:update-gh-actions
Jan 4, 2024
Merged

Use python 3.12 and update node-gyp to 10.0.1#198
cfroystad merged 1 commit intotree-sitter:masterfrom
piotrkwiecinski:update-gh-actions

Conversation

@piotrkwiecinski
Copy link
Copy Markdown
Contributor

@piotrkwiecinski piotrkwiecinski commented Dec 13, 2023 •
edited
Loading

Fixes ModuleNotFoundError: No module named 'distutils' in macos github action run.

Checklist

  • All tests pass in CI
  • There are enough tests for the new fix/feature
  • Grammar rules have not been renamed unless absolutely necessary (x rules renamed)
  • The conflicts section hasn't grown too much (x new conflicts)
  • The parser size hasn't grown too much (master: STATE_COUNT, PR: STATE_COUNT)
    (check the value of STATE_COUNT in src/parser.c)

@calebdw
Copy link
Copy Markdown
Collaborator

calebdw commented Jan 1, 2024

Is 3.12 not required for gyp?

#192 (comment)

@piotrkwiecinski
Copy link
Copy Markdown
Contributor Author

piotrkwiecinski commented Jan 2, 2024

@calebdw no. 3.12 removes one of the dependencies required by gyp.
I went with a solution used in tree-sitter/node-tree-sitter@723de6e to enforce usage of python 3.10 on all runners.

@calebdw
Copy link
Copy Markdown
Collaborator

calebdw commented Jan 2, 2024

Ah good deal. What is the long term solution though? Remove the use of distutils, install it through another means, etc.?

@calebdw calebdw mentioned this pull request Jan 2, 2024
Merged
5 tasks
@piotrkwiecinski piotrkwiecinski changed the title use python 3.10 Use python 3.12 and update node-gyp to 0.10 Jan 2, 2024
@piotrkwiecinski piotrkwiecinski changed the title Use python 3.12 and update node-gyp to 0.10 Use python 3.12 and update node-gyp to 10.0.1 Jan 2, 2024
@piotrkwiecinski
Copy link
Copy Markdown
Contributor Author

piotrkwiecinski commented Jan 2, 2024

Ok now we're on python 3.12 on all runners and I updated node-gyp to 10.0.1 which properly solves distutils issue.

@cfroystad cfroystad merged commit 594b8ba into tree-sitter:master Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@piotrkwiecinski @calebdw @cfroystad