Skip to content

Support new features#22

Merged
maxbrunsfeld merged 11 commits intotree-sitter:masterfrom
314eter:new-features
Feb 7, 2019
Merged

Support new features#22
maxbrunsfeld merged 11 commits intotree-sitter:masterfrom
314eter:new-features

Conversation

@314eter
Copy link
Copy Markdown
Collaborator

@314eter 314eter commented Jan 15, 2019

Add support for some new OCaml features.

These changes increased the compile time from 1 minute to 10 minutes. With tree-sitter 0.14.0-beta3 it's only 10 seconds.

@314eter 314eter force-pushed the new-features branch 4 times, most recently from 2f06ffc to bff973d Compare January 21, 2019 13:44
@314eter
Copy link
Copy Markdown
Collaborator Author

314eter commented Jan 21, 2019

@maxbrunsfeld I don't know why the Travis test fails. Tree-sitter says the files don't exist, but they should. When I run it locally, everything works.

@maxbrunsfeld
Copy link
Copy Markdown
Contributor

I don't know why the Travis test fails. Tree-sitter says the files don't exist

Sorry about that, I think that bug is fixed by tree-sitter/tree-sitter@92a6a69, which I'll release in 0.14.2 shortly.

@maxbrunsfeld
Copy link
Copy Markdown
Contributor

Alright, I rebuilt with the latest tree-sitter-cli release and we are ✅ .

@maxbrunsfeld
Copy link
Copy Markdown
Contributor

I'm cool with merging this if it's ready, @314eter.

@314eter
Copy link
Copy Markdown
Collaborator Author

314eter commented Feb 7, 2019

It's ready.

@maxbrunsfeld maxbrunsfeld merged commit 0ca297f into tree-sitter:master Feb 7, 2019
@314eter
Copy link
Copy Markdown
Collaborator Author

314eter commented Feb 15, 2019

@maxbrunsfeld Can you do a new release too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants