fix(wasm): load supertype tables for ABI 15 grammars#5606
Merged
Conversation
The wasm store gated supertype_symbols / supertype_map_slices / supertype_map_entries copies on abi_version > LANGUAGE_VERSION_WITH_RESERVED_WORDS, but every other consumer (language.c, query.c) treats those tables as present when abi_version >= LANGUAGE_VERSION_WITH_RESERVED_WORDS. A Wasm grammar built at ABI exactly 15 with supertype_count > 0 ends up with supertype_count copied into the native TSLanguage but supertype_map_slices left NULL. ts_query__analyze_patterns then calls ts_language_subtypes, which dereferences self->supertype_map_slices[supertype] and crashes. (cherry picked from commit a53c3b0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5605 to
release-0.26.