use provided by RedoxOS byte orders implementations#5342
Merged
clason merged 2 commits intotree-sitter:masterfrom Feb 18, 2026
Merged
use provided by RedoxOS byte orders implementations#5342clason merged 2 commits intotree-sitter:masterfrom
clason merged 2 commits intotree-sitter:masterfrom
Conversation
WillLillis
requested changes
Feb 18, 2026
Member
WillLillis
left a comment
There was a problem hiding this comment.
Adding support for redox sounds good. Just to keep things organized, could you move the defined(__redox__) below the illumos line?
Contributor
|
And commit message should be |
Contributor
Author
Thanks for the quick review! Done — moved Let me know if anything else needs tweaking! |
clason
approved these changes
Feb 18, 2026
WillLillis
approved these changes
Feb 18, 2026
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
It adds basic Redox OS support to portable/endian.h by including redox in the platform checks. Redox OS uses Relibc, which provides <endian.h> declarations for htobeXX/beXXtoh functions. This avoids the #error "platform not supported" .
The change is minimal and non-breaking for other platforms.
It was created as part of porting Helix editor to Redox OS.
Thanks.