fix(query): prevent cross-branch capture contamination in alternations with quantifiers#5320
Merged
amaanq merged 1 commit intorelease-0.26from Feb 10, 2026
Merged
Conversation
…s with quantifiers When a branch inside an alternation has a + or * quantifier, the quantifier's pass_through step loops back to the branch's first step. The alternation linking also sets that step's alternative_index to point to the next branch. This causes the quantifier loop-back to incorrectly explore other branches in the case of a failed match that follows a successful match, contaminating captures. This is corrected by redirecting the quantifier loop-back to a "clean" copy of the target step without the alternative index pointing to the next alternation branch. Co-authored-by: Riley Bruins <ribru17@hotmail.com> (cherry picked from commit 596a4d6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5317 to
release-0.26.