lib: clean up strict aliasing fixes in array.h#5309
Merged
amaanq merged 2 commits intotree-sitter:masterfrom Feb 8, 2026
Merged
lib: clean up strict aliasing fixes in array.h#5309amaanq merged 2 commits intotree-sitter:masterfrom
amaanq merged 2 commits intotree-sitter:masterfrom
Conversation
WillLillis
approved these changes
Feb 8, 2026
Member
Author
|
TLA+ is the only grammar that fails to compile with this change, which was a bug on their side. I've opened tlaplus-community/tree-sitter-tlaplus#143 to fix this. |
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In #5242, strict aliasing violations were fixed though there was this funky dance with a
Swapstruct that was unnecessary. This PR tidies it up a bit more.