fix(cli): increase verbosity of tree-sitter init -u updates#5178
fix(cli): increase verbosity of tree-sitter init -u updates#5178WillLillis merged 2 commits intotree-sitter:masterfrom
tree-sitter init -u updates#5178Conversation
|
My main concern is when things don't get updated, because that leads to discoverability issues, e.g., new fields in So in my opinion:
|
|
@clason The latest commit fills in the |
Could you give an example to help me differentiate between these two points here? |
|
Ah, sorry, they were not really different -- or rather, the third point was entirely separate: "all this being said, your changes are a strict improvement on the status quo so worth merging in any case" ("if you warn, warn better" ;)) |
Also, use `info` logs rather than `warn`
`tree-sitter init -u`
5dafc73 to
c71be2d
Compare
|
Successfully created backport PR for |
Also, use
infologs rather thanwarnOpening this to start a discussion regarding what (and how much) information should be displayed for the
tree-sitter initcommand. In this PR's current state, I've updated all log statements to useinforather thanwarn. As any updates made to a grammar's files through this command was explicitly requested via the-uflag, this seems more appropriate. I've also clarified "updating" in several logs where this could be confused with updating the dependencies in a lock file.After some feedback/discussion here, I hope we can settle on a more uniform stream of logs for the actions taken for this command. A few questions to get started: