fix(cli): trailing whitespace after multiline text nodes in CST#5135
Merged
WillLillis merged 1 commit intorelease-0.26from Dec 15, 2025
Merged
fix(cli): trailing whitespace after multiline text nodes in CST#5135WillLillis merged 1 commit intorelease-0.26from
WillLillis merged 1 commit intorelease-0.26from
Conversation
Problem: The CST printer emits trailing whitespace after multiline text nodes. With 1704c60 and `:cst` corpus tests this causes trailing spaces to appear on `test --update`. These spaces cannot be removed afterward, as the test runner expects an exact character-for-character match for CST tests. Solution: Print whitespace only if node is not multiline. (cherry picked from commit 4ac2d5d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5133 to
release-0.26.