Skip to content

Add "containing range" APIs to QueryCursor rebased#5100

Merged
WillLillis merged 4 commits intotree-sitter:masterfrom
WillLillis:query-containing-range-api_rebased
Dec 3, 2025
Merged

Add "containing range" APIs to QueryCursor rebased#5100
WillLillis merged 4 commits intotree-sitter:masterfrom
WillLillis:query-containing-range-api_rebased

Conversation

@WillLillis
Copy link
Member

@WillLillis WillLillis commented Dec 2, 2025 •
edited
Loading

This PR is just a rebased copy of the branch from #4919.

Notable changes:

  • Drop 847737b
  • Add f0f9284
    • Not a change from the original branch, but reporting parsing errors for a malformed range argument is much better than silently failing. I remember this being incredibly confusing to me when I first started using the CLI a few years ago.

TODO:

  • Implementation
  • Rust bindings
  • Web bindings
  • API docs (What and where? More complete doc comments in the header?)
  • Docs

@osiewicz @SomeoneToIgnore
@dinocosta @maxbrunsfeld @reflectronic @WillLillis
cli: Do not validate UTF-8 boundaries when query results are not being
7f5d230 
tested

Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
Co-authored-by: dino <dinojoaocosta@gmail.com>
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-authored-by: John Tur <john-tur@outlook.com>
@WillLillis WillLillis mentioned this pull request Dec 2, 2025
Closed
5 tasks
@WillLillis WillLillis force-pushed the query-containing-range-api_rebased branch 2 times, most recently from 532c6fa to f7c049a Compare December 2, 2025 04:22
@WillLillis WillLillis marked this pull request as ready for review December 2, 2025 04:25
@WillLillis WillLillis force-pushed the query-containing-range-api_rebased branch 2 times, most recently from 2518132 to 71583e3 Compare December 2, 2025 07:09
clason
clason reviewed Dec 2, 2025
View reviewed changes
@WillLillis WillLillis force-pushed the query-containing-range-api_rebased branch from 71583e3 to bc8a2a2 Compare December 3, 2025 03:51
osiewicz and others added 3 commits December 2, 2025 22:52
@osiewicz @SomeoneToIgnore
@maxbrunsfeld @dinocosta @reflectronic @WillLillis
Add containing range APIs to query cursor
d2d37d5 
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-authored-by: dino <dinojoaocosta@gmail.com>
Co-authored-by: John Tur <john-tur@outlook.com>
Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
Co-authored-by: dino <dinojoaocosta@gmail.com>
Co-authored-by: Will Lillis <will.lillis24@gmail.com>
@maxbrunsfeld @WillLillis
Clean up node range tracking in query_cursor__advance
98cf502
@WillLillis
fix(cli): improve error reporting for invalid range arguments to query
b396059 
command
@WillLillis WillLillis force-pushed the query-containing-range-api_rebased branch from bc8a2a2 to b396059 Compare December 3, 2025 03:53
@WillLillis WillLillis merged commit 888f576 into tree-sitter:master Dec 3, 2025
21 checks passed
@WillLillis WillLillis deleted the query-containing-range-api_rebased branch December 3, 2025 23:06
@maxbrunsfeld
Copy link
Contributor

maxbrunsfeld commented Dec 5, 2025

Thank you @WillLillis !

@fj4hmgdnrf-hash fj4hmgdnrf-hash mentioned this pull request Dec 5, 2025
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxbrunsfeld maxbrunsfeld maxbrunsfeld approved these changes

@clason clason clason approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WillLillis @maxbrunsfeld @clason @osiewicz