fix(generate): use correct state id when adding terminal states to non terminal extras#4792
Merged
amaanq merged 1 commit intotree-sitter:masterfrom Sep 4, 2025
Merged
Conversation
non terminal extras
e144456 to
fdf2447
Compare
amaanq
approved these changes
Sep 4, 2025
|
Successfully created backport PR for |
Contributor
|
Really nice debugging @WillLillis ⚡️⚡️⚡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
When adding terminal states for non-terminal extras, we unconditionally use the length of the parse table's state vector to assign an id to the newly added terminal state. This assumes we're going to push to
self.parse_table.states, which does not happen ifadd_parse_stateis called with a state has already been added.The Solution
Use the correct parse state id returned by
add_parse_state.choiceinextrasdefinition #1168