fix(generate): return error when single state transitions have indirectly recursive cycles#4786
Merged
amaanq merged 2 commits intotree-sitter:masterfrom Sep 4, 2025
Merged
Conversation
indirectly recursive cycles. This can cause infinite loops in the parser near EOF. Co-authored-by: Amaan Qureshi <amaanq12@gmail.com>
amaanq
approved these changes
Sep 3, 2025
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a grammar's rules can create a cycle via indirect recursion (i.e. A->B->A), this can cause parsing to loop infinitely in certain cases (i.e. near EOF). This is also just a bad idea from a grammar perspective, so we'll return an error during generation.