fix(lib): check if an ERROR node is named before assuming it's the builtin error node#4744
Merged
amaanq merged 1 commit intotree-sitter:masterfrom Aug 28, 2025
Merged
Conversation
49c18ef to
38e2db7
Compare
…builtin error node
38e2db7 to
046d5f1
Compare
clason
approved these changes
Aug 28, 2025
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Any node that is named "ERROR" will be assumed to be the built-in error node. This does not make sense for anonymous nodes, and causes issues when trying to query this node as seen in the cst grammar.
Solution
Only assume the "ERROR" node is the builtin error node if it is named and not anonymous