perf: reorder expensive conditional operand#4592
Merged
WillLillis merged 1 commit intotree-sitter:masterfrom Jul 12, 2025
Merged
perf: reorder expensive conditional operand#4592WillLillis merged 1 commit intotree-sitter:masterfrom
WillLillis merged 1 commit intotree-sitter:masterfrom
Conversation
clason
approved these changes
Jul 12, 2025
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another tiny performance win I found while trying to learn more about the generate code. In this case,
variable_is_usedis recursive and can be fairly expensive. By just reordering with the much cheapergrammar_json.word.as_ref().is_none_or(|w| w != name), we get some small wins. This typically hovers around a 1% boost for "simpler" grammars (like tree-sitter-c), while it has no measurable affect on more "complicated" ones (i.e. tree-sitter-systemverilog or tree-sitter-ocaml).