perf: reserve Vec capacities where appropriate#4571
Merged
WillLillis merged 1 commit intotree-sitter:masterfrom Jul 10, 2025
Merged
perf: reserve Vec capacities where appropriate#4571WillLillis merged 1 commit intotree-sitter:masterfrom
Vec capacities where appropriate#4571WillLillis merged 1 commit intotree-sitter:masterfrom
Conversation
clason
approved these changes
Jul 8, 2025
Contributor
|
Nim and systemverilog are the worst offenders; if they get even a few percent faster, that's a win for me. |
Member
Author
Not much of a difference for Nim: |
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replaced all usages
Vec::new()withVec::with_capacity()if a reasonable initial capacity (or lower bound) could be ascertained. This gives a slight speed boost ingenerate, for example:tree-sitter-c (4.4%):
tree-sitter-ocaml (2.5%):
tree-sitter-javascript (2.2%):