Skip to content

illumos has endian.h#4450

Merged
clason merged 1 commit intotree-sitter:masterfrom
papertigers:illumos-endian
May 15, 2025
Merged

illumos has endian.h#4450
clason merged 1 commit intotree-sitter:masterfrom
papertigers:illumos-endian

Conversation

@papertigers
Copy link
Contributor

@papertigers papertigers commented May 14, 2025 •
edited
Loading

It looks like when this code was added illumos was missed in the header file which breaks downstream projects like Helix.

test result: ok. 258 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 5.35s

     Running unittests src/main.rs (target/debug/deps/tree_sitter-f09c53668a180e2c)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests tree_sitter_cli

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

@clason
Copy link
Contributor

clason commented May 14, 2025

Not missed; deliberately omitted because I was not sure (it's not a tier 1 platform so requires community maintenance).

@papertigers papertigers mentioned this pull request May 14, 2025
Closed
@papertigers
Copy link
Contributor Author

papertigers commented May 14, 2025 •
edited
Loading

Feel free to tag me on issues involving illumos if you would like.
Although since I am a helix-editor user I will probably run into them naturally myself if something does break.

@clason clason merged commit 4339b0f into tree-sitter:master May 15, 2025
14 checks passed
@tree-sitter-ci-bot
Copy link

tree-sitter-ci-bot bot commented May 15, 2025

Successfully created backport PR for release-0.25:

@tree-sitter-ci-bot tree-sitter-ci-bot bot mentioned this pull request May 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clason clason clason approved these changes

Assignees

No one assigned

Labels

c-library ci:backport release-0.25 Backport label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@papertigers @clason