Skip to content

fix(lib): return early for empty predicate step slice#4440

Merged
WillLillis merged 1 commit intotree-sitter:masterfrom
WillLillis:predicate_patch
May 11, 2025
Merged

fix(lib): return early for empty predicate step slice#4440
WillLillis merged 1 commit intotree-sitter:masterfrom
WillLillis:predicate_patch

Conversation

@WillLillis
Copy link
Member

This PR pulls the bug fix out of #4430 so that it can be included in our upcoming release.

cc @clason

@WillLillis
Copy link
Member Author

Not sure if I'll have to pull in the CI fix from that PR as well, the failures were very weird and may have been spurious.

@clason
Copy link
Contributor

clason commented May 11, 2025

Let's see what CI says to that ;)

@WillLillis WillLillis merged commit 31b9717 into tree-sitter:master May 11, 2025
14 checks passed
@WillLillis WillLillis deleted the predicate_patch branch May 11, 2025 12:57
@WillLillis
Copy link
Member Author

Absolutely bizarre

@tree-sitter-ci-bot
Copy link

Successfully created backport PR for release-0.25:

@clason
Copy link
Contributor

clason commented May 11, 2025

CI likes it :) (I suspected the refactors were what triggered the CI failures, if germane, not the fix.)

@WillLillis
Copy link
Member Author

The original failure was because glibc couldn't be found: https://github.com/tree-sitter/tree-sitter/actions/runs/14818456114/job/41602144090?pr=4430

After I pushed a commit editing the install list for cross, it passed on a test PR on my fork but failed in tree-sitter. After clearing the cache on tree-sitter, it passed without any changes. Not sure what could have caused that, maybe something went wrong with GH's runner?

In any case at least things are green now.

@clason
Copy link
Contributor

clason commented May 11, 2025

Possible. Those workflows are... involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants