Fix test_flatten_grammar_with_recursive_inline_variable#4404
Merged
clason merged 1 commit intotree-sitter:masterfrom Jun 6, 2025
Merged
Fix test_flatten_grammar_with_recursive_inline_variable#4404clason merged 1 commit intotree-sitter:masterfrom
clason merged 1 commit intotree-sitter:masterfrom
Conversation
Member
|
Oh wow, good catch. The generate crate's tests should be running, but isn't since we didn't pass in |
bc3fe5e to
aba28c2
Compare
Member
|
Let me know if my changes look good to you @jamessan, thanks! |
Contributor
Author
CI still isn't running all tests, because it's using |
Contributor
|
Be careful what you wish for ;) |
Contributor
Author
|
Should we maybe separate the bug fix from the broader CI changes? |
Contributor
|
Yes! |
8144323 to
929992d
Compare
…ne_variable` The period was dropped in the `thiserror` refactor (79444e0), which caused the `test_flatten_grammar_with_recursive_inline_variable` test to fail. Signed-off-by: James McCoy <jamessan@jamessan.com>
929992d to
fcb7c99
Compare
clason
approved these changes
Jun 6, 2025
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
thiserrorrefactor in #4048 dropped the period in the message forFlattenGrammar::RecursiveInline.Due to this, the
test_flatten_grammar_with_recursive_inline_variablehas been failing since.Restore the period to the error message to fix the test and add testing of tree-sitter-grammar to CI to avoid future regressions. This adds at most 15s to each platform that runs the tests.
I wasn't sure if there was a reason why the "test" xtask wasn't being used to test, so I took the conservative approach of just adding explicit testing for tree-sitter-grammar.