fix(xtask): properly trim emscripten version at the source#4402
Merged
maxbrunsfeld merged 2 commits intotree-sitter:masterfrom Apr 28, 2025
Merged
fix(xtask): properly trim emscripten version at the source#4402maxbrunsfeld merged 2 commits intotree-sitter:masterfrom
maxbrunsfeld merged 2 commits intotree-sitter:masterfrom
Conversation
clason
approved these changes
Apr 27, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that
cargo xtask fetch-emscriptenwas failing because of the same newline issue I fixed in #4365.trim_asciiis available inconstcontexts, so it makes more sense to just fix this at the source rather than hoping we catch all current (and future) uses of this string.Edit: Marking this as a draft for now until the lint/wasm issue are resolved.