fix(bindings): report wasm store error in rust bindings set_language#4348
Merged
WillLillis merged 1 commit intotree-sitter:masterfrom Apr 15, 2025
Merged
fix(bindings): report wasm store error in rust bindings set_language#4348WillLillis merged 1 commit intotree-sitter:masterfrom
set_language#4348WillLillis merged 1 commit intotree-sitter:masterfrom
Conversation
clason
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the rust bindings's
set_languagesilently ignores failures from the C side involving the wasm store. This just changes theLanguageErrorstruct into an enum representing both error states.Closes #4345