fix(rust): address new clippy lint for pointer comparisons#4305
Merged
clason merged 1 commit intotree-sitter:masterfrom Mar 25, 2025
Merged
fix(rust): address new clippy lint for pointer comparisons#4305clason merged 1 commit intotree-sitter:masterfrom
clason merged 1 commit intotree-sitter:masterfrom
Conversation
clason
approved these changes
Mar 23, 2025
Contributor
|
Prefer |
c1d83a8 to
1e5f68d
Compare
Contributor
|
CodeQL complains about two more instances of raw pointer comparison -- do you want to include those here as well? |
Contributor
|
Nevermind, probably just needs a rebase to remove those. EDIT Yup; will merge when CI is green. |
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
core::ptr::eqrather than the suggestedstd::ptr::eqto maintainno_stdcompatibility.