I tried applying your patch locally but still got a compile error related to the Drop implementation for Parser:

error[E0599]: no method named `stop_printing_dot_graphs` found
    --> /home/lillis/projects/tree-sitter/lib/binding_rust/lib
.rs:1435:14
     |
1435 |         self.stop_printing_dot_graphs();
     |              ^^^^^^^^^^^^^^^^^^^^^^^^ method not found 
in `&mut Parser`

For more information about this error, try `rustc --explain E0
599`.
error: could not compile `tree-sitter` (lib) due to 1 previous
 error

It looks like locking the call to stop_printing_dot_graphs behind the std feature fixes things:

diff --git a/lib/binding_rust/lib.rs b/lib/binding_rust/lib.rs
index 62839d9b..8577fb1d 100644
--- a/lib/binding_rust/lib.rs
+++ b/lib/binding_rust/lib.rs
@@ -1432,7 +1432,10 @@ impl Parser {

 impl Drop for Parser {
     fn drop(&mut self) {
-        self.stop_printing_dot_graphs();
+        #[cfg(feature = "std")]
+        {
+            self.stop_printing_dot_graphs();
+        }
         self.set_logger(None);
         unsafe { ffi::ts_parser_delete(self.0.as_ptr()) }
     }

Maybe worth a no_std test case?

A new test case would be welcome, but could also be taken care of in a followup.

A new test case would be welcome, but could also be taken care of in a followup.

I would strongly encourage adding a test now. Otherwise it'll likely never happen and things can easily backslide. (In fact, I would always start with the test so you know which changes to make to have it work.)

I've pushed the above fix for the call to stop_printing_dot_graphs, thanks for that - however I'm unsure of how go about setting up the no_std test case. The repo has a Dockerfile set up to test with CMD cargo test --all-features, could it be as easy as just running cargo test --no-default-features afterward?

Just looking for some direction on how this should be acheived, cheers!

cargo test --no-default-features still works for me locally without this patch, so I don't think that's the way to go. What about something like this added to .github/workflows/build.yml?

    - name: Check no_std
      if: ${{ !matrix.no-run && inputs.run-test }}
      run: |
        cd ..
        cargo new no_std_check
        cd no_std_check
        echo "tree-sitter = { path = \"../tree-sitter/lib/\", default-features = false, features = [] }" >> Cargo.toml
        cargo build

CC @ObserverOfTime?

What about cargo build --no-default-features ?

What about cargo build --no-default-features ?

That succeeds when it's run from the root directory, but fails with the expected errors when I run it inside lib/. I'm not sure why it succeeds in the former case, but that should work regardless, thanks!

@Tiggilyboo do you mind adding the CI changes, or would you prefer for me to push to your branch?

Sorry for the delay, I've added the build check in the workflow. Let me know if anything looks off

Git push to origin failed for release-0.25 with exitcode 1