Skip to content

fix(xtask): using reqwest instead of ureq to fix #4295#4299

Closed
xiaoma20082008 wants to merge 1 commit intotree-sitter:masterfrom
xiaoma20082008:master
Closed

fix(xtask): using reqwest instead of ureq to fix #4295#4299
xiaoma20082008 wants to merge 1 commit intotree-sitter:masterfrom
xiaoma20082008:master

Conversation

@xiaoma20082008
Copy link

fix #4295 by using reqwest that which is based on system-native TLS

@clason
Copy link
Contributor

clason commented Mar 19, 2025

Thank you, but we don't want to pull in dozens of new dependencies for a simple task that updates a single number. A better fix would be to rewrite the task itself to use simple git calls.

@clason clason closed this Mar 19, 2025
@ObserverOfTime
Copy link
Member

That would be inefficient as it would require cloning the repository.

@clason
Copy link
Contributor

clason commented Mar 20, 2025

Nonsense. git ls-remote.

@clason
Copy link
Contributor

clason commented Apr 25, 2025

As ureq is now an internal dependency, this has become relevant. But I'm still not happy with the inflated dependency chain -- isn't there are more light-weight alternative? We don't use it for much...

@clason
Copy link
Contributor

clason commented Apr 25, 2025

Hmm, reqwest looks like the go-to HTTPS crate for Rust; everything else seems to be implemented on top of that. So I guess this is fine but can you please

  1. rebase on master
  2. and also switch the new ureq call to reqwest?

@clason
Copy link
Contributor

clason commented Apr 25, 2025

Superseded by #4396, but thanks!

@clason clason closed this Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider changing dependency on ureq

3 participants