fix(xtask): using reqwest instead of ureq to fix #4295#4299
Closed
xiaoma20082008 wants to merge 1 commit intotree-sitter:masterfrom
Closed
fix(xtask): using reqwest instead of ureq to fix #4295#4299xiaoma20082008 wants to merge 1 commit intotree-sitter:masterfrom
xiaoma20082008 wants to merge 1 commit intotree-sitter:masterfrom
Conversation
Contributor
|
Thank you, but we don't want to pull in dozens of new dependencies for a simple task that updates a single number. A better fix would be to rewrite the task itself to use simple |
Member
|
That would be inefficient as it would require cloning the repository. |
Contributor
|
Nonsense. |
Contributor
|
As |
Contributor
|
Hmm,
|
Contributor
|
Superseded by #4396, but thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4295 by using reqwest that which is based on
system-native TLS