Change (Node | null)[] return types to Node[]#4283
Merged
amaanq merged 1 commit intotree-sitter:masterfrom Mar 15, 2025
Merged
Conversation
Contributor
|
It looks like some type assertions in the tests are no longer necessary. Could you remove those, so that the lint passes for the tests? |
6764a36 to
1a71593
Compare
Contributor
Author
|
@maxbrunsfeld Done. |
Member
|
thanks @tmr232! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the rewrite for web-tree-sitter 0.25, some functions that used to return
Node[]were changed to(Node | null)[].This makes using them tricky, as it requires filtering out the
nullvalues.But from what I gather - they don't actually return
nullvalues now either.Given the way the C part is written, if I understand correctly, those functions should always return a
Node[], and have nonullelements.This PR adds non-null assertions to change those type signatures and make using the functions the same as with previous versions.