Skip to content

Update build.zig.zon for zig master/0.14#4258

Merged
clason merged 1 commit intotree-sitter:masterfrom
nihklas:master
Mar 10, 2025
Merged

Update build.zig.zon for zig master/0.14#4258
clason merged 1 commit intotree-sitter:masterfrom
nihklas:master

Conversation

@nihklas
Copy link
Contributor

@nihklas nihklas commented Mar 4, 2025

In a recently landed change (ziglang/zig#22994), the structure of the build.zig.zon file changed. This PR fixes the structure to be compatible with the newest master build and coming 0.14 release.

@clason
Copy link
Contributor

clason commented Mar 4, 2025

Note that master should report as 0.26.0; that should be fixed before other build file changes.

@nihklas
Copy link
Contributor Author

nihklas commented Mar 4, 2025

I'm sorry if that is an obvious question, but that is something I just have to wait for? Or is there something I need to do?
This is my first PR to tree-sitter so if there are some things I didn't do correctly/completely, I apologize

@clason
Copy link
Contributor

clason commented Mar 4, 2025

I think that's too much to ask for from a first contributor. The structure of this project is... messy.

@nihklas
Copy link
Contributor Author

nihklas commented Mar 4, 2025

Alright, No Problem. Then I'll just wait. If there are updates and I need to do changes regarding this PR, let me know!

@bfredl
Copy link
Contributor

bfredl commented Mar 10, 2025

fingerprint is unrelated to version (depends on the name only), so this could just go in already.

@clason clason merged commit 1850762 into tree-sitter:master Mar 10, 2025
13 checks passed
@clason clason added ci:backport release-0.25 Backport label build Related to building (Makefile, CMake, etc.) labels May 12, 2025
@tree-sitter-ci-bot
Copy link

Backport failed for release-0.25, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-0.25
git worktree add -d .worktree/backport-4258-to-release-0.25 origin/release-0.25
cd .worktree/backport-4258-to-release-0.25
git switch --create backport-4258-to-release-0.25
git cherry-pick -x 185076211821953f1e765cec4f8b24dbb16f47f6

1 similar comment
@tree-sitter-ci-bot
Copy link

Backport failed for release-0.25, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-0.25
git worktree add -d .worktree/backport-4258-to-release-0.25 origin/release-0.25
cd .worktree/backport-4258-to-release-0.25
git switch --create backport-4258-to-release-0.25
git cherry-pick -x 185076211821953f1e765cec4f8b24dbb16f47f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Related to building (Makefile, CMake, etc.) ci:backport release-0.25 Backport label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants