fix(lib): prevent finished_tree assertion failure#4176
Merged
amaanq merged 1 commit intotree-sitter:masterfrom Feb 1, 2025
Merged
fix(lib): prevent finished_tree assertion failure#4176amaanq merged 1 commit intotree-sitter:masterfrom
amaanq merged 1 commit intotree-sitter:masterfrom
Conversation
Contributor
Author
|
Of course the error shows up right after release 🫠 |
Contributor
|
That's ok, day-one patch releases are a tradition. |
Member
|
🤦 Thanks @ribru17 Can you move your test into the one above? A lot of it is redundant, we can just call reset and add the additional check |
bac9ede to
74c4bfd
Compare
amaanq
reviewed
Feb 1, 2025
**Problem:** When resetting the parser during subtree balancing, an error is thrown: ``` parser.c:2198: ts_parser_parse: Assertion `self->finished_tree.ptr' failed. ``` **Solution:** Reset `canceled_balancing` to false in `ts_parser_reset()`.
74c4bfd to
8941531
Compare
amaanq
approved these changes
Feb 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When resetting the parser during subtree balancing, an error is thrown:
Solution: Reset
canceled_balancingto false ints_parser_reset().