feat(loader): implement language_for_configuration#3816
Merged
amaanq merged 1 commit intotree-sitter:masterfrom Nov 9, 2024
Merged
feat(loader): implement language_for_configuration#3816amaanq merged 1 commit intotree-sitter:masterfrom
language_for_configuration#3816amaanq merged 1 commit intotree-sitter:masterfrom
Conversation
1 task
Loader::language_for_configuration.language_for_configuration
c3e962e to
7add73a
Compare
7add73a to
32423b9
Compare
Member
|
What's the use case for this? It sounds like whatever grammar(s) you're using should be migrating to the new config |
Contributor
Author
|
Yes, they should, and maybe they could, and I wish that they would, but if wishes were horses then beggars would ride, and all that. In the meantime something as trivial as this would help cross a few gaps. In my particular case I’m stuck on some older grammars that I don’t control, and while forking is an option it’d be nice if there was a single simple solution such as the one I’m proposing. |
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While diagnosing a breaking change introduced by v0.24 (specifically #3700; I left a comment there), I found that there is actually no way to directly load a
Languagefrom a givenLanguageConfiguration(such as one returned fromLoader::get_all_language_configurations). This PR trivially remedies that.