Skip to content

build: bump deps#3428

Closed
amaanq wants to merge 1 commit intotree-sitter:masterfrom
amaanq:bump
Closed

build: bump deps#3428
amaanq wants to merge 1 commit intotree-sitter:masterfrom
amaanq:bump

Conversation

@amaanq
Copy link
Copy Markdown
Member

@amaanq amaanq commented Jun 23, 2024

bumps dependencies to latest versions (incl. wasmtime to v22)

@clason
Copy link
Copy Markdown
Contributor

clason commented Jul 5, 2024

It looks like you need the cmake crate to build wasmtime-c-api now?

@ObserverOfTime
Copy link
Copy Markdown
Member

So is it time to use CMake as our build system?

@CGamesPlay
Copy link
Copy Markdown
Contributor

Now that bytecodealliance/wasmtime#9102 is merged and wasmtime v23.0.2 is released, it should be possible to use 23.0.2 as the version for wasmtime without requiring any build setup changes.

@clason
Copy link
Copy Markdown
Contributor

clason commented Aug 13, 2024

...except for adding the cmake crate as a dependency.

@CGamesPlay
Copy link
Copy Markdown
Contributor

I'm afraid I don't have the context here. cmake crate is a transitive dependency, yes, but it does not need to be added to the Cargo.toml of this project. Perhaps more relevant is that the cmake binary has to be installed on the build system. Is this going to continue to be a blocker for tree-sitter upgrading?

@clason
Copy link
Copy Markdown
Contributor

clason commented Aug 13, 2024

That is what Max was concerned about, yes. It's not a problem for CI since GitHub runners have cmake preinstalled.

@amaanq
Copy link
Copy Markdown
Member Author

amaanq commented Aug 17, 2024

Closing as outdated

@amaanq amaanq closed this Aug 17, 2024
@github-actions github-actions bot removed the request for review from maxbrunsfeld August 17, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants