Skip to content

Don't minify JavaScript#3380

Merged
ObserverOfTime merged 2 commits intotree-sitter:masterfrom
verhovsky:dont-minify
Jul 29, 2024
Merged

Don't minify JavaScript#3380
ObserverOfTime merged 2 commits intotree-sitter:masterfrom
verhovsky:dont-minify

Conversation

@verhovsky
Copy link
Copy Markdown
Contributor

@verhovsky verhovsky commented May 22, 2024

The difference is 74KB (or 91KB without the terser step because -O3 already does minification emscripten-core/emscripten#7916 ) vs 121KB. Users can minify their JavaScript themselves if they want to.

Fixes #3379

@verhovsky verhovsky marked this pull request as draft May 22, 2024 17:05
@verhovsky verhovsky marked this pull request as ready for review May 22, 2024 17:28
@verhovsky verhovsky changed the title Don't minify JS Don't minify JS and add source maps for --debug May 22, 2024
@verhovsky verhovsky marked this pull request as draft May 22, 2024 17:46
@verhovsky verhovsky marked this pull request as ready for review May 22, 2024 18:05
@verhovsky verhovsky force-pushed the dont-minify branch 2 times, most recently from fadbfb7 to d91eb4d Compare May 23, 2024 14:33
@verhovsky verhovsky changed the title Don't minify JS and add source maps for --debug Don't minify JavaScript May 23, 2024
Copy link
Copy Markdown
Member

@ObserverOfTime ObserverOfTime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase and remove terser from the dev dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't minify tree-sitter.js

2 participants