Skip to content

Replace Guava Joiner with JDK8 equivalents#224

Merged
exoego merged 1 commit intomasterfrom
joiner
Jan 26, 2023
Merged

Replace Guava Joiner with JDK8 equivalents#224
exoego merged 1 commit intomasterfrom
joiner

Conversation

@exoego
Copy link
Contributor

@exoego exoego commented Jan 26, 2023

Part of #135

@exoego exoego added the dependencies Pull requests that update a dependency file label Jan 26, 2023
@exoego exoego marked this pull request as ready for review January 26, 2023 06:59
yuokada
yuokada approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@yuokada yuokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@exoego exoego merged commit 5fae45b into master Jan 26, 2023
@exoego exoego deleted the joiner branch January 26, 2023 13:07
@exoego exoego added chore internal changes (not user-facing) and removed dependencies Pull requests that update a dependency file labels Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuokada yuokada yuokada approved these changes

Assignees

No one assigned

Labels

chore internal changes (not user-facing)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@exoego @yuokada