Added presubmit script distilled from that in trillian#29
Added presubmit script distilled from that in trillian#29mhutchinson merged 1 commit intotransparency-dev:mainfrom
Conversation
Removed some of the flags and branches that weren't needed, such as code generation. This isn't hooked into CI _yet_, but at least developers can run `./scripts/presubmit.sh` before submitting in the meantime.
Codecov Report
@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage 88.93% 88.93%
=======================================
Files 7 7
Lines 497 497
=======================================
Hits 442 442
Misses 50 50
Partials 5 5 Continue to review full report at Codecov.
|
|
Do you reckon this script is github-actionable? |
I'm planning on making it consistent with the other repos, which have GCB run a docker container that performs all of the checks. If we foresee only ever wanting the linter (but we'd need to drop the licence check from presubmit) then maybe we could look at https://github.com/golangci/golangci-lint-action. |
|
Consistency across repos is the best thing, SGTM. I like the simplicity of actions, it worked well for this |
Removed some of the flags and branches that weren't needed, such as code
generation. This isn't hooked into CI yet, but at least developers can
run
./scripts/presubmit.shbefore submitting in the meantime.