Conversation
|
Converting back to draft to avoid accidental merging, until the issues mentioned in #654 (comment) are resolved |
A complete libsixel implementation in rust. "libsixel" is now no longer used.
|
@Porkepix could you try this PR again? I have reverted to a earlier viuer version for now, which still has |
I'd say it looks fine from little testing. I also saw you opened several issues upstream, maybe you should add it's clear regression between 0.10 and 0.11 then, running some bisect on it if you can build from local copy could help upstream. Is viuer relying on the other create you opened an issue for this, or is it unrelated in the end? |
I did mention in viuer EDIT: i re-read what i wrote in the viuer issue, i did not explicitly mention that 0.10.0 is fine, but even then, like i said 0.11.0 only made the issue more apparent.
It is related and unrelated. |
My bad, either I saw it before, or I just didn't read thoroughly enough then! |
This PR updates viuer to the latest version, which adds support for more terminals.
Also switch to use
icy_sixelinviuerwhich is a pure-rust (lib)sixel implementation, which makes us no longer requirelibsixeland build on practically any target.Due to caution, i have not yet enabled the sixel cover feature by default.