Add SHA256 hash#93
Merged
Merged
Conversation
woodruffw
reviewed
Dec 16, 2024
woodruffw
reviewed
Dec 16, 2024
Comment on lines
+667
to
668
| #[pyo3(signature = (data, nonce, cert, hash_algorithm=None))] | ||
| pub(crate) fn create_timestamp_request( |
Contributor
There was a problem hiding this comment.
Nitpick, nonblocking: it's unfortunate that the default here is None instead of HashAlgorithm.SHA512, but I don't think PyO3 would allow us to set the latter anyways.
Not a blocker.
woodruffw
approved these changes
Dec 16, 2024
woodruffw
left a comment
Contributor
There was a problem hiding this comment.
LGTM, nice work @DarkaMaul!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support setting
SHA256as a Hash function for the request.