verify: Actually expose verify_message in the API#153
Merged
DarkaMaul merged 1 commit intoMay 20, 2025
Conversation
Previously we returned a _Verifier from VerifierBuilder.build(): this hid the fact that verify_message() is not actually part of the Verifier API. Add verify_message() to the API
d4425a9 to
119e0c6
Compare
Contributor
Author
|
Using mypy in tests would have exposed this: I did not add it in this PR since the tests do have a bit of accessing internal fields and such which would need to be handled to get mypy running smoothly. |
Collaborator
|
Great catch! I agree, we should probably run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we returned a _Verifier from VerifierBuilder.build(): this hid the fact that verify_message() is not actually part of the Verifier API.
Add verify_message() to the API
Fixes #152