fix typo about "algorithm"#131
Merged
Merged
Conversation
|
|
woodruffw
approved these changes
Mar 28, 2025
woodruffw
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, thanks for this change.
(As you note this is technically a breaking change, but IMO it isn't a serious risk in this case.)
DarkaMaul
approved these changes
Mar 31, 2025
DarkaMaul
left a comment
Collaborator
There was a problem hiding this comment.
Thank you so much for submitting this PR. Your contribution is greatly appreciated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Maintainer,
It's awesome project! I noticed a minor typo and created this PR to address it.
This change includes a breaking change to an argument name at
hash_algorithm. Please review carefully if this aligns with your intended API design.No pressure at all – feel free to close this PR if it doesn't fit your roadmap! Either way, thank you for your work on this project. 🙏