Add setting to use <input type="datetime-local"> for datetime pickers
#204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `make format` on a clean copy of this repository made these changes
This boilerplate commit adds a `DatetimeInputStyle` field to user settings on both the client and server. It can represent either "Fancy" (this is the input element currently present in Traggo) or "Standard" (unimplemented, the <input type="datetime-local"> HTML element). A later commit will actually do something with this commit.
jmattheis
requested changes
Apr 12, 2025
Member
jmattheis
left a comment
There was a problem hiding this comment.
Thanks for the contribution, remarks in sub comments.
Minnowo
reviewed
Apr 12, 2025
Contributor
Author
Thanks for the review! I don't have anything to add to your remarks; I've updated the branch accordingly. |
jmattheis
reviewed
Apr 24, 2025
jmattheis
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fancy
DateTimeSelector, while indeed aesthetically pleasing, are a little unweildy and difficult to update manually. This PR adds a setting to replace them with the newer HTML standard<input type="datetime-local">pickers, which grant the same functionality with much better accessibility. The default setting is to retain the previousDateTimeSelectorstyle.