Skip to content

fix(sdk): crewai tracing provider conflict #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nirga merged 1 commit into from
Nov 25, 2025
Merged

fix(sdk): crewai tracing provider conflict #3470

nirga merged 1 commit into from
Nov 25, 2025

Conversation

@nirga
Copy link
Member

@nirga nirga commented Nov 25, 2025 •
edited by coderabbitai bot
Loading

Disabled CrewAI Telemetry (https://docs.crewai.com/en/telemetry#telemetry) that caused warnings on sample apps.

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

Important

Sets CREWAI_DISABLE_TELEMETRY to true in init_crewai_instrumentor() to prevent telemetry conflicts.

  • Behavior:
    • Sets CREWAI_DISABLE_TELEMETRY environment variable to true in init_crewai_instrumentor() in tracing.py to prevent telemetry conflicts when crewai package is installed.

This description was created by Ellipsis for b14aabf. You can customize this summary. It will automatically update as commits are pushed.

Summary by CodeRabbit

  • Bug Fixes
    • CrewAI integration now automatically disables telemetry by default during initialization

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 25, 2025 •
edited
Loading

Walkthrough

The init_crewai_instrumentor function in the tracing module now sets the CREWAI_DISABLE_TELEMETRY environment variable to "true" using os.environ.setdefault before importing CrewAIInstrumentor, establishing a pre-import telemetry configuration.

Changes

Cohort / File(s) Change Summary
CrewAI Telemetry Configuration
packages/traceloop-sdk/traceloop/sdk/tracing/tracing.py		 Added pre-import environment flag setting that disables CrewAI telemetry via os.environ.setdefault("CREWAI_DISABLE_TELEMETRY", "true") in init_crewai_instrumentor before importing CrewAIInstrumentor

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify the telemetry flag is set at the correct point in the import lifecycle
  • Confirm os.environ.setdefault behavior aligns with intended configuration semantics (non-override of existing values)
  • Ensure this pre-import configuration doesn't introduce unexpected side effects with existing CrewAI integration behavior

Poem

🐰 A flag set before the import dance,
Telemetry silenced with a single glance,
Pre-configuration, neat and clean,
The tidiest flow I've ever seen! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the fix for a CrewAI tracing provider conflict, directly relating to the code change that disables telemetry to resolve conflicts.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch crewai-warning
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1ca74fe and b14aabf.

📒 Files selected for processing (1)
  • packages/traceloop-sdk/traceloop/sdk/tracing/tracing.py (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.py: Store API keys only in environment variables/secure vaults; never hardcode secrets in code
Use Flake8 for code linting and adhere to its rules

Files:

  • packages/traceloop-sdk/traceloop/sdk/tracing/tracing.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Test Packages (3.10)
  • GitHub Check: Test Packages (3.11)
  • GitHub Check: Test Packages (3.12)
  • GitHub Check: Build Packages (3.11)
  • GitHub Check: Lint
🔇 Additional comments (1)
packages/traceloop-sdk/traceloop/sdk/tracing/tracing.py (1)

1032-1044: CrewAI telemetry env flag is set safely and in the right place

Setting CREWAI_DISABLE_TELEMETRY via os.environ.setdefault before importing CrewAIInstrumentor correctly disables CrewAI’s own telemetry by default without overriding an explicit user setting. This looks consistent with the rest of the instrumentation init patterns and shouldn’t introduce regressions.

Comment @coderabbitai help to get the list of available commands and usage tips.

ellipsis-dev[bot]
ellipsis-dev bot reviewed Nov 25, 2025
View reviewed changes
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to b14aabf in 32 seconds. Click for details.
  • Reviewed 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/traceloop-sdk/traceloop/sdk/tracing/tracing.py:1034
  • Draft comment:
    The added line sets CREWAI_DISABLE_TELEMETRY to 'true' to disable telemetry and avoid conflicts. It would be helpful to add an inline comment clarifying that this is intentional behavior to resolve crewai tracing provider conflicts (and that it won’t override an already-set value).
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_4P8vCQPE2T1umk9h

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@nirga nirga merged commit c11d45a into main Nov 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellipsis-dev ellipsis-dev[bot] ellipsis-dev[bot] left review comments

@doronkopit5 doronkopit5 doronkopit5 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nirga @doronkopit5