packages/opentelemetry-instrumentation-anthropic/tests/test_messages.py (1)

2898-2898: Remove debug print from test output.

Leftover print clutters CI logs.

-    print(f"Number of spans created: {len(spans)}")

packages/opentelemetry-instrumentation-anthropic/opentelemetry/instrumentation/anthropic/streaming.py (6)

44-48: Fix confusing empty-string literal.

"""""" works via literal concatenation but is non-idiomatic. Use "".

-                complete_response["events"][index]["input"] = """"""
+                complete_response["events"][index]["input"] = ""

---

109-116: Use isinstance() for numeric checks.

type(x) is int excludes subclasses and is brittle.

-    if token_histogram and type(input_tokens) is int and input_tokens >= 0:
+    if token_histogram and isinstance(input_tokens, int) and input_tokens >= 0:
@@
-    if token_histogram and type(completion_tokens) is int and completion_tokens >= 0:
+    if token_histogram and isinstance(completion_tokens, int) and completion_tokens >= 0:

Also applies to: 118-125

---

180-190: Consider preserving additional helpers (get_final_text).

You restored get_final_message, text_stream, until_done. Add get_final_text to cover another commonly used helper.

-        elif name == 'until_done':
+        elif name == 'until_done':
             return self._instrumented_until_done
+        elif name == 'get_final_text':
+            return self._instrumented_get_final_text

And implement:

+    def _instrumented_get_final_text(self):
+        for _ in self:
+            pass
+        return self.__wrapped__.get_final_text()

---

191-197: Avoid getattr with constant attribute.

Direct attribute access is clearer and satisfies linters.

-        original_get_final_message = getattr(self.__wrapped__, 'get_final_message')
-        return original_get_final_message()
+        return self.__wrapped__.get_final_message()

---

331-341: Also preserve get_final_text in async wrapper.

Parity with sync path.

-        elif name == 'until_done':
+        elif name == 'until_done':
             return self._instrumented_until_done
+        elif name == 'get_final_text':
+            return self._instrumented_get_final_text

And implement:

+    async def _instrumented_get_final_text(self):
+        async for _ in self:
+            pass
+        return await self.__wrapped__.get_final_text()

---

342-351: Avoid getattr with constant attribute (async).

-        original_get_final_message = getattr(self.__wrapped__, 'get_final_message')
-        return await original_get_final_message()
+        return await self.__wrapped__.get_final_message()

packages/opentelemetry-instrumentation-anthropic/tests/test_messages.py (4)

2845-2851: Silence Ruff ARG001 on unused fixtures.

Fixtures are intentionally unused for side-effects; add # noqa: ARG001 to the function def line to keep linters happy.

-async def test_anthropic_streaming_helper_methods_legacy(
+async def test_anthropic_streaming_helper_methods_legacy(  # noqa: ARG001
     instrument_legacy, async_anthropic_client, span_exporter, log_exporter, reader
 ):

---

2876-2882: Silence Ruff ARG001 on unused fixtures.

-async def test_anthropic_text_stream_helper_method_legacy(
+async def test_anthropic_text_stream_helper_method_legacy(  # noqa: ARG001
     instrument_legacy, async_anthropic_client, span_exporter
 ):

---

2903-2909: Silence Ruff ARG001 on unused fixtures.

-def test_anthropic_sync_streaming_helper_methods_legacy(
+def test_anthropic_sync_streaming_helper_methods_legacy(  # noqa: ARG001
     instrument_legacy, anthropic_client, span_exporter
 ):

---

2909-2924: Actually exercise a sync helper to validate preservation.

The test name implies helper coverage, but it only iterates events. Consider asserting get_final_message() or using text_stream.

-        # Collect all events
-        events = []
-        for event in stream:
-            events.append(event)
-        assert len(events) > 0
+        # Validate helper works
+        text = "".join(stream.text_stream)
+        assert len(text) > 0

packages/opentelemetry-instrumentation-anthropic/opentelemetry/instrumentation/anthropic/__init__.py (2)

560-572: Avoid potential mis-wrap: check for Stream explicitly in sync path.

Guard against an unexpected AsyncStream being wrapped by the sync wrapper by narrowing the condition.

Apply:

-    if is_streaming_response(response):
+    if isinstance(response, Stream):
         return AnthropicStream(
             span,
             response,
             instance._client,
             start_time,
             token_histogram,
             choice_counter,
             duration_histogram,
             exception_counter,
             event_logger,
             kwargs,
         )

Notes:

• Please confirm all wrapped sync methods here can only return anthropic._streaming.Stream. If any can return AsyncStream, this change is required.
• Minor nit: end_time = time.time() on Line 558 is now unused for streaming paths; consider removing to satisfy flake8 F841.

---

682-693: Mirror the precise type check in async path.

Use AsyncStream to prevent accidental sync-wrapper usage.

Apply:

-    if is_streaming_response(response):
+    if isinstance(response, AsyncStream):
         return AnthropicAsyncStream(
             span,
             response,
             instance._client,
             start_time,
             token_histogram,
             choice_counter,
             duration_histogram,
             exception_counter,
             event_logger,
             kwargs,
         )

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.