Skip to content

fix(ci): lock version#75

Merged
doronkopit5 merged 6 commits intomainfrom
dk/fix-docker-version-issue
Nov 27, 2025
Merged

fix(ci): lock version#75
doronkopit5 merged 6 commits intomainfrom
dk/fix-docker-version-issue

Conversation

@doronkopit5
Copy link
Member

@doronkopit5 doronkopit5 commented Nov 27, 2025 •
edited
Loading

Fixes TLP-1213

Important

Update slab version in Cargo.lock and lock sqlx-cli version in Dockerfile.db-based-migrations.

  • Dependencies:
    • Update slab package version from 0.4.10 to 0.4.11 in Cargo.lock.
    • Lock sqlx-cli version to 0.8.6 in Dockerfile.db-based-migrations using --locked flag.

This description was created by Ellipsis for dcab169. You can customize this summary. It will automatically update as commits are pushed.

Summary by CodeRabbit

  • Chores
    • Updated internal build process to enhance dependency installation consistency and reproducibility.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2025 •
edited
Loading

Walkthrough

The cargo install command for sqlx-cli in the Dockerfile was updated to include the --locked flag, ensuring that the Cargo.lock file is honored during dependency installation.

Changes

Cohort / File(s) Change Summary
Build command enhancement
Dockerfile.db-based-migrations		 Added --locked flag to cargo install command to enforce lockfile consistency during sqlx-cli installation

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A lock is secured, a flag is set true,
Our migrations now faithful to versions we knew,
One simple addition, a guarantee made,
No surprises in builds—lock flags never fade! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(ci): lock version' directly relates to the main change: adding the --locked flag to the cargo install command in the CI Dockerfile, which ensures dependency versions are locked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dk/fix-docker-version-issue
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e7094bc and dcab169.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Dockerfile.db-based-migrations (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: Analyze (rust)
🔇 Additional comments (1)
Dockerfile.db-based-migrations (1)

4-4: Remove --locked flag—cargo install does not support this argument.

The --locked flag is not valid for cargo install and will cause the build to fail with "unrecognized argument" error. The --locked flag only applies to cargo build, cargo check, cargo test, and cargo run.

Remove --locked from line 4:

-RUN cargo install sqlx-cli --version 0.8.6 --no-default-features --features postgres --locked
+RUN cargo install sqlx-cli --version 0.8.6 --no-default-features --features postgres

Likely an incorrect or invalid review comment.

Comment @coderabbitai help to get the list of available commands and usage tips.

@doronkopit5 doronkopit5 marked this pull request as ready for review November 27, 2025 09:52
ellipsis-dev[bot]
ellipsis-dev bot reviewed Nov 27, 2025
View reviewed changes
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to dcab169 in 52 seconds. Click for details.
  • Reviewed 29 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Dockerfile.db-based-migrations:9
  • Draft comment:
    Consider setting DEBIAN_FRONTEND=noninteractive to avoid interactive prompts during apt-get update/install.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50% None
2. Dockerfile.db-based-migrations:24
  • Draft comment:
    ENTRYPOINT is acceptable; consider CMD for flexibility if command overrides are desired.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50% None

Workflow ID: wflow_54oJygSYW9D5iCjn

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

OzBenSimhonTraceloop
OzBenSimhonTraceloop approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@OzBenSimhonTraceloop OzBenSimhonTraceloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have issue with hub version, commitizen can't push to this repo, its need to be fixed

@doronkopit5 doronkopit5 merged commit 9d2e3ba into main Nov 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellipsis-dev ellipsis-dev[bot] ellipsis-dev[bot] left review comments

@OzBenSimhonTraceloop OzBenSimhonTraceloop OzBenSimhonTraceloop approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@doronkopit5 @OzBenSimhonTraceloop