[UnitaryHACK] Implemented BBM92.py#109
Merged
stephendiadamo merged 3 commits intotqsd:masterfrom May 21, 2021
Merged
Conversation
stephendiadamo
requested changes
May 21, 2021
Collaborator
stephendiadamo
left a comment
There was a problem hiding this comment.
Can you change the path to examples/QKD/...? Then it'll go into the other QKD examples already implemented.
Otherwise looks good.
Collaborator
|
If you like, you can also consider writing a page in the documentation for your example and it can go online in the demonstrations. |
stephendiadamo
approved these changes
May 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to implement the BBM92 QKD protocol. I have focused on the key part only.
NOTE: I am trying these QKD protocols by learning, reading papers, watching videos and then trying it to implement it in code. So if there is some mistake in the code and also if there is mistake in my concept or I have understood the concept wrongly, please do tell me. I am also learning.