Open
Conversation
…rom branch tqdv-2.2.10)
…er than SpriteIndex, which is no longer unique
…odaysGifts... Though I'm not sure I've ever actually seen the UI that it's creating...
NermNermNerm
commented
Dec 7, 2023
| else if (itemName.IndexOf("sprinkler", StringComparison.OrdinalIgnoreCase) >= 0) | ||
| { | ||
| // Relative tile positions to the placable items locations - need to pass coordinates | ||
| AddTilesToHighlightedArea(currentItem.GetSprinklerTiles(), (int)validTile.X, (int)validTile.Y); |
Author
There was a problem hiding this comment.
This change is a little bit worrisome because Object.GetSprinklerTiles didn't semantically change in 1.6... But it did change. Somebody noodled over it and changed a variable name. However, its behavior got changed by something else - in the past it was zero-based - as Object.tileLocation used to be 0.0 for unplaced objects, and now it's the tile that's being hovered over. That new behavior might not be intended and might get rolled back.
Added unmilled rice and translations.
|
Hey @NermNermNerm @KryptoST @SteveBenz the original project is still in development over at Annosz/UIInfoSuite2! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm new to SDV modding, but I just can't live without this one, even if I'm just testing out my own stuff, so I took the time to port it 1.6. I don't want to own the mod going forward or anything, I just want to share what I've got, and you seem like the principal maintainer of the thing at the moment.
Currently it compiles and runs well in vanilla 1.6. The biggest question mark to me is the "Dynamic Game Assets" code. I have no idea how or when it runs - my suspicion is that it's important for big mods that introduce new crops &c. I suspect it all needs to be chucked out for 1.6 because of the difference in how Items ID's are handled.
Smaller stuff that I intend to get to is validating that mills and junimo huts work correctly.
There may also be failures that I don't know to look for - e.g. tooltips that should be shown but aren't.