Skip to content

Revert "Fix bug with incorrectly defactorized dependencies (#772)"#905

Merged
obestwalter merged 3 commits into
tox-dev:masterfrom
Avira:master
Jul 12, 2018
Merged

Revert "Fix bug with incorrectly defactorized dependencies (#772)"#905
obestwalter merged 3 commits into
tox-dev:masterfrom
Avira:master

Conversation

@obestwalter

Copy link
Copy Markdown
Member

Quick and dirty for a patch release fixing a regression.

This (partially) reverts commit 765c977

  • leave original test for fix as reproducer
  • leave changed assertion in previous test that is now failing commented out

This reverts commit 765c977

* leave original test for fix as reproducer
* leave changed assertion in previous test that is now failing commented out
This reverts commit 765c977

* leave original test for fix as reproducer
* leave changed assertion in previous test that is now failing commented out
@codecov

codecov Bot commented Jul 12, 2018

Copy link
Copy Markdown

Codecov Report

Merging #905 into master will decrease coverage by 1.43%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
- Coverage   92.62%   91.19%   -1.44%     
==========================================
  Files          12       12              
  Lines        2331     2327       -4     
  Branches      408      408              
==========================================
- Hits         2159     2122      -37     
- Misses        109      140      +31     
- Partials       63       65       +2
Impacted Files Coverage Δ
src/tox/config.py 95.65% <100%> (-0.27%) ⬇️
src/tox/interpreters.py 69.84% <0%> (-19.05%) ⬇️
src/tox/venv.py 91.66% <0%> (-1.2%) ⬇️
src/tox/_pytestplugin.py 91.51% <0%> (-0.45%) ⬇️
src/tox/session.py 91.22% <0%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f73fe3e...e86d99d. Read the comment docs.

This reverts commit 765c977 to fix the regression in #899

* leave original test for fix as reproducer
* leave changed assertion in previous test that is now failing commented out
@obestwalter obestwalter merged commit b1e526d into tox-dev:master Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant