Skip to content

🐛 fix(schema): add additionalProperties to partial-tox.json#3824

Merged
gaborbernat merged 1 commit intotox-dev:mainfrom
gaborbernat:3818
Feb 25, 2026
Merged

🐛 fix(schema): add additionalProperties to partial-tox.json#3824
gaborbernat merged 1 commit intotox-dev:mainfrom
gaborbernat:3818

Conversation

@gaborbernat
Copy link
Copy Markdown
Member

@gaborbernat gaborbernat commented Feb 25, 2026

Tools like tombi that validate pyproject.toml against SchemaStore schemas in strict mode reject valid [tool.tox] keys such as env_list, requires, env, and env_run_base. 🔍 The root cause is that SchemaStore's partial-tox.json wrapper references tox.json via allOf but lacks explicit additionalProperties: true, and tombi's strict mode treats missing additionalProperties as false.

The release workflow now generates and pushes partial-tox.json alongside tox.json to SchemaStore, ensuring the partial schema always includes additionalProperties: true. A tombi.toml configures local schema validation against the repo's own tox.schema.json, so both tox.toml and pyproject.toml with [tool.tox] sections are validated with tombi lint using the local schema rather than depending on SchemaStore being correct.

Fixes #3823

SchemaStore's partial-tox.json was missing additionalProperties: true,
causing tombi's strict mode to reject valid [tool.tox] keys.

Fixes tox-dev#3823
@gaborbernat gaborbernat enabled auto-merge (squash) February 25, 2026 13:44
@gaborbernat gaborbernat disabled auto-merge February 25, 2026 14:06
@gaborbernat gaborbernat merged commit b5154d1 into tox-dev:main Feb 25, 2026
51 of 53 checks passed
@gaborbernat gaborbernat deleted the 3818 branch March 9, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided bug:normal affects many people or has quite an impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

false positive schema validations errors with tombi and pyproject.toml tox files

1 participant